E2E Cleanup: Implement SendGameServerUDP #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
added
kind/cleanup
|
Build Failed 😱 Build Id: 87500771-10cc-4889-9d3a-ef627bc15119 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Renamed `PingGameServer` to `SendUDP`, as I think that explans the function better, and also implemented a utility function of `SendGameServerUDP` for sending messages to GameServers. Kept SendUDP as we use it to e2e test the Ping UDP endpoints.
|
Build Failed 😱 Build Id: 7a41957b-298a-4c0c-95cd-b7f183943e02 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: 26c04cd3-35b3-4ffe-b847-2100c66bfb15 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
jkowalski
approved these changes
Mar 9, 2019
|
Build Succeeded 👏 Build Id: 116a0760-781e-48e9-a599-f5565b444986 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
PingGameServertoSendUDP, as I think that explains the function better, and also implemented a utility function ofSendGameServerUDPfor sending messages to GameServers.Kept
SendUDPas we use it to e2e test the Ping UDP endpoints.